Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore name argument on Python 3.7 #2355

Merged
merged 10 commits into from Jan 6, 2022
Merged

Ignore name argument on Python 3.7 #2355

merged 10 commits into from Jan 6, 2022

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Jan 4, 2022

We need to ignore the name argument on Python 3.7

@ahopkins ahopkins requested a review from a team as a code owner January 4, 2022 13:30
prryplatypus
prryplatypus previously approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@prryplatypus prryplatypus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add a test for this?

ashleysommer
ashleysommer previously approved these changes Jan 4, 2022
View reviewed changes
@ahopkins
Copy link
Member Author

ahopkins commented Jan 4, 2022

Do we want to add a test for this?

Sure. If nothing else it will boost our cov %

@Tronic
Copy link
Member

Tronic commented Jan 5, 2022

I tend to bring this up every now and then, but this might also be a time to consider dropping Python 3.7 support. Even Debian is at 3.9 and other distros have already moved to 3.10. MacOS ships with 3.8 and Microsoft Store has 3.10.

@ahopkins
Copy link
Member Author

ahopkins commented Jan 5, 2022

I tend to bring this up every now and then, but this might also be a time to consider dropping Python 3.7 support. Even Debian is at 3.9 and other distros have already moved to 3.10. MacOS ships with 3.8 and Microsoft Store has 3.10.

We probably will by the end of the year. I see no compelling reason to do it just yet. The place where I see the biggest pain-point is with Sanic Extensions, which is already 3.8+. We do still see about 10-15% of our downloads from 3.7.

@ahopkins ahopkins requested review from ashleysommer and a team January 5, 2022 23:13
prryplatypus
prryplatypus previously approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@prryplatypus prryplatypus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add a test to prevent #2356 from happening again in the future?

sanic/app.py Outdated Show resolved Hide resolved
sanic/app.py Show resolved Hide resolved
@ahopkins ahopkins requested a review from a team as a code owner January 6, 2022 08:21
@ahopkins ahopkins merged commit a23547d into 21.12LTS Jan 6, 2022
@ahopkins ahopkins deleted the task-name-3.7 branch January 6, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prryplatypus prryplatypus prryplatypus left review comments

@ashleysommer ashleysommer Awaiting requested review from ashleysommer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ahopkins @Tronic @ashleysommer @prryplatypus @SaidBySolo