-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unpin uvloop #2129
unpin uvloop #2129
Conversation
Codecov Report
@@ Coverage Diff @@
## 20.12LTS #2129 +/- ##
==========================================
Coverage 92.778% 92.778%
==========================================
Files 29 29
Lines 3268 3268
Branches 573 573
==========================================
Hits 3032 3032
Misses 159 159
Partials 77 77 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve, but for several reasons we are not going to go back to supporting Python 3.6 for v21. But, this is good for v20.12
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is incorrect, please respond with an update. Thank you for your contributions. |
This isn't stale |
MagicStack/uvloop#401 now sets python_requires
and so as long as you ignore the broken versions of uvloop==0.15.0 and 0.15.1so you can still support py3.6 here0.15.0 and 0.15.1 have been yanked so this pinning can go away completely!