Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow httpx 0.23.0 #38

Closed
novotl opened this issue May 23, 2022 · 4 comments · Fixed by #39
Closed

Allow httpx 0.23.0 #38

novotl opened this issue May 23, 2022 · 4 comments · Fixed by #39

Comments

@novotl
Copy link

novotl commented May 23, 2022

httpx < 0.23.0 contains security vulnerability GHSA-h8pj-cxx2-jfg2 that was fixed in httpx = 0.23.0 in:

The version containing the hotfix is currently not allowed

sanic-testing/setup.py

Lines 49 to 51 in 04b1b96

requirements = [
"httpx>=0.18,<0.23"
]

@novotl novotl changed the title Upgrade to httpx 0.23.0 Allow httpx 0.23.0 May 23, 2022
@ahopkins
Copy link
Member

Thanks. I have been very hesitant to release the upper bound because of the history of the project to introduce breaking changes.

@ahopkins
Copy link
Member

@novotl Looks like it runs okay. Would you submit a PR for the change?

@ctrlaltf24 ctrlaltf24 mentioned this issue May 23, 2022
Merged
@novotl
Copy link
Author

novotl commented May 24, 2022

Thanks @nshaaban-cPacket for submitting a PR #39!

@ghost
Copy link

ghost commented Jun 2, 2022

@ahopkins What's your opinion using aiohttp?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow HTTPX 0.23 ctrlaltf24/sanic-testing
2 participants
@ahopkins @novotl