Add a function to stop packs from being downloaded #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sandertv
reviewed
Oct 3, 2022
minecraft/dial.go
Outdated
| // DownloadResourcePack is called individually for every texture and behaviour pack sent by the connection when | ||
| // using Dialer.Dial(), and can be used to stop the pack from being downloaded. The function is called with the UUID | ||
| // and version of the resource pack, and the boolean returned determines if the pack will be downloaded or not. | ||
| DownloadResourcePack func(packUUID uuid.UUID, version string) bool |
There was a problem hiding this comment.
Would rename packUUID as id but otherwise this is ready to go I think.
| @@ -835,6 +841,9 @@ func (conn *Conn) handleResourcePacksInfo(pk *packet.ResourcePacksInfo) error { | |||
| conn.packQueue.packAmount-- | |||
| continue | |||
| } | |||
| if conn.downloadResourcePack != nil && !conn.downloadResourcePack(uuid.MustParse(pack.UUID), pack.Version) { | |||
| continue | |||
There was a problem hiding this comment.
Shouldn't you decrement packAmount here?
There was a problem hiding this comment.
Hmmm yeah this seems to be an issue. I think currently this will break if some of the packs are ignored, but not all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.