New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verify
argument for Client.__init__
#341
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 202 202
=========================================
Hits 202 202 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When would this get used? I don’t want to encourage people to not use/verify SSL, but maybe there is a use case I’m not thinking of.
verify
needs to be added to the doc string args with a description of how to use it. This is used to auto generate the docs.
When using the intranet,meilisearch can be connected by http with api key verifying.The |
Co-authored-by: Paul Sanders <psanders1@gmail.com>
Co-authored-by: Paul Sanders <psanders1@gmail.com>
for more information, see https://pre-commit.ci
It is possible to use http but would be bad practice. Doing this the api key would be un-encrypted and easy to steal. |
Sorry, I missed you said intranet and not internet. That makes sense. Looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rolemee
Turning off ssl verification when using http can save a lot of resources