Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pagination Settings #313

Merged
merged 3 commits into from Oct 14, 2022
Merged

Conversation

Makiyu-py
Copy link
Contributor

@Makiyu-py Makiyu-py commented Oct 14, 2022

Closes #282.

  • Add model for pagination details in the settings models

  • Add new methods for pagination setting to the index

    • GET
    • PATCH
    • DELETE
  • Add tests

Sorry if I couldn't get to add tests for pagination settings, I don't have docker installed in my machine.. my bad 😅. Can you add the tests yourself?

But I did use all the functions myself (via a cloud instance with the small_movies dataset) and it worked fantastically.

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (eea2469) compared to base (616b1ea).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #313   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          193       196    +3     
=========================================
+ Hits           193       196    +3     
Impacted Files Coverage Δ
meilisearch_python_async/models/settings.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Makiyu-py! I got the tests added.

I'm not sure if it would have helped you but there are multiple ways you can use Meilisearch for the tests, it doesn't have to be Docker. I think I am going to add something to the CONTRIBUTING guide about this because it isn't clear with the way it is written now.

@sanders41 sanders41 merged commit 73063ce into sanders41:main Oct 14, 2022
@sanders41 sanders41 added feature enhancement New feature or request and removed feature labels Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pagination settings to the index.
3 participants