Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 16 #23

Open
rainerhahnekamp opened this issue Aug 24, 2023 · 7 comments · May be fixed by #46
Open

Support for Angular 16 #23

rainerhahnekamp opened this issue Aug 24, 2023 · 7 comments · May be fixed by #46
Labels
enhancement New feature or request

Comments

@rainerhahnekamp
Copy link

When I upgrade to Angular 16 and install the dependencies of the example app via npm, playwright test fails with the following error message:

TypeError: plugin.default is not a function

You can take a look at it here: https://github.com/rainerhahnekamp/playwright-ct-angular/tree/ng-16.2

@rainerhahnekamp rainerhahnekamp added the enhancement New feature or request label Aug 24, 2023
@sand4rt
Copy link
Owner

sand4rt commented Aug 24, 2023

Hey @rainerhahnekamp 👋 Thanks for creating the issue. Will look into it.
I always enjoy your talks BTW, especially about testing :) If you have more feedback or want to help out, please let me know!

@rainerhahnekamp
Copy link
Author

Hello, thank you very much for the compliment. I will definitely do more now in the area of component testing with Playwright. It is quite possible that one of my next videos/talks is about this project here.

@rainerhahnekamp
Copy link
Author

rainerhahnekamp commented Sep 1, 2023

@sand4rt Unfortunately I don't know how to reach you. Would it be possible for you to contact me at rainer.hahnekamp@gmail.com? I would like to discuss options on how to get your work merged into Playwright.

Thank you.

@sand4rt
Copy link
Owner

sand4rt commented Sep 24, 2023

Hey @rainerhahnekamp the TypeError: plugin.default is not a function error should be gone now. I haven't fully tested Angular 16 yet. Do you see any other issues?

BTW, cool that you recently gave a workshop to a colleague of mine😄

@rainerhahnekamp
Copy link
Author

Hello @sand4rt, thanks a lot. I will check it out and let you know.

I was not aware that a colleague of yours was part of that workshop. What a coincidence :)

@sand4rt
Copy link
Owner

sand4rt commented Oct 29, 2023

Hi @rainerhahnekamp, I wanted to inform you that there's an open PR at the Playwright repository for merging this library. Your feedback would be valuable there as well :)
microsoft/playwright#27783

@rainerhahnekamp
Copy link
Author

Thanks @sand4rt, haven't done so much in terms of Playwright component testing (except producing hot air ;) ). So, I will show up there and cheer you up a little bit.

@sand4rt sand4rt linked a pull request Feb 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants