From 3c0d5ea5f811f9d03722d222666eed78ab9854b8 Mon Sep 17 00:00:00 2001 From: sancar Date: Wed, 1 Jul 2020 13:29:45 +0300 Subject: [PATCH] Log terminate in finest when the client is closing ReliableTopicMessageListener should not warn the user when the client is shutting down. InstanceNotActiveException is already in finest. This pr makes ClientNotActiveException log level finest too. fixes https://github.com/hazelcast/hazelcast/issues/17070 --- .../client/proxy/ClientReliableMessageRunner.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hazelcast-client/src/main/java/com/hazelcast/client/proxy/ClientReliableMessageRunner.java b/hazelcast-client/src/main/java/com/hazelcast/client/proxy/ClientReliableMessageRunner.java index 8c68e779d2ca..4cd5775a29aa 100644 --- a/hazelcast-client/src/main/java/com/hazelcast/client/proxy/ClientReliableMessageRunner.java +++ b/hazelcast-client/src/main/java/com/hazelcast/client/proxy/ClientReliableMessageRunner.java @@ -16,6 +16,7 @@ package com.hazelcast.client.proxy; +import com.hazelcast.client.HazelcastClientNotActiveException; import com.hazelcast.client.HazelcastClientOfflineException; import com.hazelcast.core.Member; import com.hazelcast.logging.ILogger; @@ -63,7 +64,13 @@ protected Member getMember(ReliableTopicMessage m) { @Override protected boolean handleInternalException(Throwable t) { - if (t instanceof HazelcastClientOfflineException) { + if (t instanceof HazelcastClientNotActiveException) { + if (logger.isFinestEnabled()) { + logger.finest("Terminating MessageListener " + listener + " on topic: " + topicName + ". " + + " Reason: HazelcastClient is shutting down"); + } + return false; + } else if (t instanceof HazelcastClientOfflineException) { if (logger.isFinestEnabled()) { logger.finest("MessageListener " + listener + " on topic: " + topicName + " got exception: " + t + ". Continuing from last known sequence: " + sequence);