Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and move symbols #54

Open
technetium opened this issue Apr 21, 2024 · 2 comments
Open

Add and move symbols #54

technetium opened this issue Apr 21, 2024 · 2 comments

Comments

@technetium
Copy link

I'd like the the option for visitors to add symbols and move them and store the symbols and order in local storage. Is somebody working on that already?

@samwho
Copy link
Owner

samwho commented Apr 21, 2024

This crossed my mind a few days ago, but to my knowledge nobody is working on it. I don't plan to add it myself, but I would happily review a PR if it's something you're interested in doing!

The way I'm envisioning this working (after only an hour or so of thinking about it, so feel free to suggest other ideas), is an unobtrusive + button next to the search box that pops up a form/modal for adding your own symbols. Custom symbols would then appear first in the list, and be visually distinct from the "default" ones. They would save into local storage and be available on the device you've saved them on. No plans for any auth or cross-device syncing.

@technetium
Copy link
Author

My plan was to add a square, the same size of the symbols at the end of the symbols. I like your plus next to the search button better.

If nobody is working on it, I'll first make the adding of symbols. They will be just added as the first symbol.

Next step will be the possibility to change the order of the symbols.

I don't see any benefit of having the "defaults" be visually different. I do see a benefit of having visual distinct classes for different symbols (e.g. accented characters, math symbols) Maybe adding check boxes for different classes? Could make the added ones having a different default class than the default ones.

Indeed every thing stored in local storage. Cross device syncing will be left as an exercise for other developers ;-)

technetium added a commit to technetium/symbol that referenced this issue Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants