Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph combines test and app packages into a single package #9

Open
dmitri-minkin opened this issue Jul 20, 2022 · 0 comments
Open

Graph combines test and app packages into a single package #9

dmitri-minkin opened this issue Jul 20, 2022 · 0 comments

Comments

@dmitri-minkin
Copy link

Graphwerk combines both app/games and spec/games package into single package: package/games.

I used the same directory structure and ran both graphwerk and pocky on the same folder which gave different results.
I think graphwerk has a bug.

Directory structure:

sportsball
 |- app
     |-packages
         |- games
              |- package.yml
         ... etc
 |- spec
     |-packages
         |- games
              |- package.yml
         ... etc

Notice that test (spec) package depends on the appropriate app package, that is spec/games depends on app/games:

in sportsball/spec/packages/games/package.yml :

enforce_dependencies: true
enforce_privacy: false
dependencies:
  - app/packages/games

But on diagram we get single package package/games that references itself which is wrong.
Basically graphwerk combined both app/games and spec/games package into single package: package/games

Additional info

in sportsball/app/packages/games/package.yml :

enforce_dependencies: true
enforce_privacy: false
dependencies:
  - app/packages/rails_shims
  - app/packages/teams

the only deprecated_references.yml file is under root:
sportsball/deprecated_references.yml

# This file contains a list of dependencies that are not part of the long term plan for ..
# We should generally work to reduce this list, but not at the expense of actually getting work done.
#
# You can regenerate this file using the following command:
#
# bin/packwerk update-deprecations .
---
app/packages/games:
  "::Game":
    violations:
    - dependency
    files:
    - spec/support/object_creation_methods.rb
app/packages/teams:
  "::Team":
    violations:
    - dependency
    files:
    - spec/support/object_creation_methods.rb

Graphwerk result of running:
bundle exec rake graphwerk:update

packwerk.png

Pocky result of running:
rake pocky:generate"[root]"
packwerk.png

@dmitri-minkin dmitri-minkin changed the title Graph combines test and app packages into single package in the graph Graph combines test and app packages into a single package Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant