limit the length of generics._limit_assigned_parameters
#4083
+84
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
changed the title
generics._limit_assigned_parameters
4 tasks
samuelcolvin
commented
May 18, 2022
davidhyman
reviewed
May 18, 2022
samuelcolvin
added a commit
that referenced
this pull request
May 19, 2022
samuelcolvin
added a commit
that referenced
this pull request
May 19, 2022
samuelcolvin
added a commit
that referenced
this pull request
May 19, 2022
squarebridges
pushed a commit
to nicejobinc/pydantic
that referenced
this pull request
Jun 24, 2022
) * limit the length of generics._limit_assigned_parameters * switch to using _limit_cache_size for both * add change description * correct `_limit_cache_size` cache * implemented LimitedDict * try using UserDict * try upgrading cython * stop LimitedDict from inheriting from dict * separate LimitedDict for typing checking :-( * fix for __class_getitem__
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
As per discussion in #3829 this should avoid memory "leaks" when generating lots of generics.
Related issue number
#3829 - I won't mark this as fixed until confirmed by users.
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change