Adds dataclass_transform to dataclass
#4007
Merged
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@samuelcolvin |
|
I'll look soon, might be after pycon though. |
|
please review |
1 task
|
this needs to be rebased from msater to fix CI. |
2 tasks
squarebridges
pushed a commit
to nicejobinc/pydantic
that referenced
this pull request
Jun 24, 2022
* ✨ Adds dataclass_transform to dataclasses * ✨ Adds dataclass_transform to dataclasses Co-authored-by: Samuel Colvin <s@muelcolvin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR continues #2721 by adding
__dataclass_transform__decorator to the pydantic dataclass decorator so that pyright can infer the__init__method as well as the instance attributes and types.For more info about this decorator make sure to check out #2721.
Related issue number
Fixes #4006
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)