Fix missing port in HttpUrl.build() result #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
samuelcolvin
reviewed
Apr 2, 2022
|
please update. |
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
|
Fixed, please check |
|
thanks so much. |
ntaylorwss
pushed a commit
to nicejobinc/pydantic
that referenced
this pull request
Jun 24, 2022
* Port number is no longer being ignored by HttpUrl.build() * Update tests/test_networks.py Co-authored-by: Samuel Colvin <samcolvin@gmail.com> * Update networks.py * Update tests/test_networks.py Co-authored-by: Samuel Colvin <samcolvin@gmail.com> * Update test_networks.py * Update test_networks.py * update change description Co-authored-by: Samuel Colvin <samcolvin@gmail.com> Co-authored-by: Samuel Colvin <s@muelcolvin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Previously passing the
portargument intoHttpUrl.build()method has lead to including this port number to the output:But a regression was introduced in #2447.
It looks like the desired behavior was to hide default port number for the protocol, but instead any port number was just being ignored.
So I've fixed a check, that only default port numbers become hidden, like
80forhttpor443tohttps. Non-default port numbers are left unchanged.Also I've added a test to cover this case.
Related issue number
No
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)