drop python3.6 support #3605
Merged
drop python3.6 support #3605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PrettyWood would love your opinion if you have some time. |
PrettyWood
approved these changes
Jan 2, 2022
| @@ -104,7 +77,8 @@ def get_all_type_hints(obj: Any, globalns: Any = None, localns: Any = None) -> A | |||
|
|
|||
| def get_origin(t: Type[Any]) -> Optional[Type[Any]]: | |||
| if type(t).__name__ in AnnotatedTypeNames: | |||
| return cast(Type[Any], Annotated) # mypy complains about _SpecialForm in py3.6 | |||
| # weirdly this is a runtime requirement, as well as for mypy | |||
There was a problem hiding this comment.
Ye, things like this scare me a little 😨.
5 tasks
samuelcolvin
added a commit
that referenced
this pull request
May 14, 2022
samuelcolvin
added a commit
that referenced
this pull request
May 14, 2022
samuelcolvin
added a commit
that referenced
this pull request
May 19, 2022
ntaylorwss
pushed a commit
to nicejobinc/pydantic
that referenced
this pull request
Jun 24, 2022
* drop python3.6 support * revert small change * fix 3.7 failures * more cases and cleanup * add change description
ntaylorwss
pushed a commit
to nicejobinc/pydantic
that referenced
this pull request
Jul 7, 2022
* drop python3.6 support * revert small change * fix 3.7 failures * more cases and cleanup * add change description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Drop support for python3.6 which has reached EOL.
This suggests that python 3.6 still makes up around 5% of downloads, but that should drop quickly now, and you have to break some eggs to make an omlet.
Related issue number
Don't remember what issue we discussed this on, but we previously agreed to drop python 3.6 suport after v1.9 was released.
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)