apply update_forward_refs to json_encoders
#3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@zrothberg and @PrettyWood I'd love your feedback on this. |
|
Its essentially the same code I had. The only thing I was unsure of is if the |
samuelcolvin
changed the title
update_forward_refs to json_encoders
|
I think this is satisfactory, I'll merge tomorrow. |
ntaylorwss
pushed a commit
to nicejobinc/pydantic
that referenced
this pull request
Jun 24, 2022
* apply update_forward_refs to json_encoders, fix pydantic#3583 * linting * mypy * avoid use of ForwardRef with python3.6 * fix ForwardRef usage, take 2 * coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Apply
update_forward_refstoConfig.json_encodesprevent name clashes in types defined via strings.Related issue number
fix #3583
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)