build(deps): bump mypy from 0.920 to 0.930 #3573
Conversation
Due to python/mypy#11332, mypy would crash because `__builtins__` is not part of `ctx.api` modules, `builtins` is
|
Looks good, can we add a change description? Seems sad up introduce all those "type ignores", is that our fault or mypy's fault? Does this need to be noted in the docs and/or marked as a breaking change? |
Yes, the latest pydantic release supports mypy 0.910 but this drops support for mypy < 0.930. I think this change should be released in pydantic 2.0.0. |
|
I think we just add a "breaking change" note in the changelog and go for it. |
|
I would expect zero breaking changes between v1.8.2 and v1.9.0 -- does pydantic use semver, or some other versioning scheme? |
|
Not strictly, see other releases.
Unfortunately that's not realistic, in pydantic or any other software. |
|
Maybe I should’ve said “zero intentional breaking changes”. :~) Could you help me understand the downside to releasing a new major version? IMO putting a “breaking change” like in the changelog for a minor version should raise a parsing error.
EDIT: I looked at our changelogs and can see that Pydantic regularly includes breaking changes in minor releases. I have questions about this policy but they're unrelated to this specific PR -- we can table this, sorry for the noise. |
Ye, I agree with you that this would be a better approach. I want to get v2 (with big changes to how validation and validators work) out in the new year. After that, I think we should move to strict semvar and more regular major releases. |
|
I'm going to merge this and add a change description elsewhere. |
* cleanup bumping mypy to 0.930, #3573 * add tests for old mypy * tweak test-old-mypy job * alter mypy plugin to work with older versions * mypy.py compatibility with multiple versions * fix mypy tests to allow for varied output * toml parsing, fix #3579 * formatting :-( * ignore missing types for toml package * remove unused ignore_missing_imports * undo removal of ignore_missing_imports for dotenv * tweak coverage ignore * fully uninstall mypy and toml/tomli
* build(deps): bump mypy from 0.920 to 0.930 * fix: avoid mypy plugin crash Due to python/mypy#11332, mypy would crash because `__builtins__` is not part of `ctx.api` modules, `builtins` is * fix tests
* cleanup bumping mypy to 0.930, pydantic#3573 * add tests for old mypy * tweak test-old-mypy job * alter mypy plugin to work with older versions * mypy.py compatibility with multiple versions * fix mypy tests to allow for varied output * toml parsing, fix pydantic#3579 * formatting :-( * ignore missing types for toml package * remove unused ignore_missing_imports * undo removal of ignore_missing_imports for dotenv * tweak coverage ignore * fully uninstall mypy and toml/tomli
Change Summary
Related issue number
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)