Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention Python >= 3.9.2 as an alternative to typing_extensions.TypedDict #3374

Merged
merged 6 commits into from Dec 11, 2021

Conversation

BvB93
Copy link
Contributor

@BvB93 BvB93 commented Oct 30, 2021

Change Summary

Pydantic does not support older versions of typing.TypedDict due to bpo-42059, thus recomminding the use of typing_extensions.TypedDict instead. This issue was resolved in python 3.9.2 though, so mention upgrading python as an alternative to the typing_extensions-based approach.

Related issue number

n.a.

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@BvB93
Copy link
Contributor Author

BvB93 commented Oct 30, 2021

please review

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise makes sense.

pydantic/annotated_types.py Outdated Show resolved Hide resolved
@samuelcolvin
Copy link
Member

please update

Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
@PrettyWood PrettyWood merged commit e012089 into pydantic:master Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants