fix: nested ORM from nested dictionaries #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrettyWood
commented
Sep 6, 2021
| class Getter(GetterDict): | ||
| # try to read the modified property name | ||
| # either as an attribute or as a key | ||
| def get(self, key, default): | ||
| key = key + key | ||
| try: | ||
| return self._obj[key] | ||
| v = self._obj[key] | ||
| return Getter(v) if isinstance(v, dict) else v |
There was a problem hiding this comment.
@nuno-andre Would it make sense to you?
|
Good catch! Noticed this one too on |
|
Came across this issue with a similar case to the existing test, but slightly different: from typing import List, Optional
from pydantic import BaseModel
class User(BaseModel):
name: str
value: Optional[str] = None
class Config:
orm_mode = True
class UserList(BaseModel):
__root__: List[User]
UserList(__root__=[{"name": "aa", "value": "123"}])Maybe it can be added as a test case. Same as with #3181; it used to work but doesn't on master. |
|
Please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Related issue number
closes #3181
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)