Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dark color scheme for docs #2913

Merged
merged 3 commits into from Sep 4, 2021
Merged

Conversation

gbdlin
Copy link
Contributor

@gbdlin gbdlin commented Jun 15, 2021

Change Summary

Added alternative, dark color scheme for docs, which should be automatically activated if user's browser presents the prefers-color-scheme: dark media query.

Screen Shot 2021-09-04 at 8 13 31 PM

Related issue number

None

Checklist

  • Unit tests for the changes exist
    documentation configuration change, not needed?
  • Tests pass on CI and coverage remains at 100%
    documentation configuration change, not needed?
  • Documentation reflects the changes where applicable
    documentation configuration change, not needed?
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

    documentation configuration change, not needed?
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Added alternative, dark color scheme for docs, which should be automatically activated if user's browser presents the `prefers-color-scheme: dark` media query.
@gbdlin
Copy link
Contributor Author

gbdlin commented Jun 15, 2021

please review

@PrettyWood
Copy link
Member

Cool! Thanks a lot! 🙏
I just switched the two bulb icons to have the light one (switch to light mode) in dark mode. Makes more sense to me

@PrettyWood PrettyWood merged commit abbad5e into pydantic:master Sep 4, 2021
jpribyl pushed a commit to liquet-ai/pydantic that referenced this pull request Oct 7, 2021
* Added dark color scheme for docs

Added alternative, dark color scheme for docs, which should be automatically activated if user's browser presents the `prefers-color-scheme: dark` media query.

* switch icons

* add change file

Co-authored-by: PrettyWood <em.jolibois@gmail.com>
@rafrafek
Copy link

I clicked the icon and now it is no longer automatic. How to make it auto dark (sync with the OS) back again? My MacBook is switching to light/dark mode automatically and I like when everything is synced to it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants