Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with config decl at class level #2532

Merged
merged 4 commits into from May 9, 2021
Merged

Fix issue with config decl at class level #2532

merged 4 commits into from May 9, 2021

Conversation

uriyyo
Copy link
Contributor

@uriyyo uriyyo commented Mar 16, 2021

Change Summary

Fix issue with config decl at class level

Related issue number

Fixes #2522

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Mar 16, 2021 •
edited

Codecov Report

Merging #2532 (c10e03b) into master (4ec6c52) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2532   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         5109      5110    +1     
  Branches      1050      1051    +1     
=========================================
+ Hits          5109      5110    +1
Impacted Files Coverage Δ
pydantic/main.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec6c52...c10e03b. Read the comment docs.

PrettyWood
PrettyWood reviewed Mar 16, 2021
View reviewed changes
Copy link
Member

@PrettyWood PrettyWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise thanks!

pydantic/main.py Outdated Show resolved Hide resolved
changes/2532-uriyyo.md Outdated Show resolved Hide resolved
@PrettyWood PrettyWood added the bug V1 Bug related to Pydantic V1.X label Mar 16, 2021
uriyyo and others added 2 commits March 17, 2021 10:02
@uriyyo @PrettyWood
Update pydantic/main.py
aacf3c8 
Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>
@uriyyo
Update changes
c10e03b
@uriyyo uriyyo requested a review from PrettyWood March 17, 2021 08:05
PrettyWood
PrettyWood approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@PrettyWood PrettyWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PrettyWood PrettyWood added this to the v1.8.2 milestone Mar 30, 2021
@samuelcolvin samuelcolvin merged commit 0a5f0fa into pydantic:master May 9, 2021
@samuelcolvin
Copy link
Member

great, thank you so much.

samuelcolvin pushed a commit that referenced this pull request May 11, 2021
@uriyyo @PrettyWood @samuelcolvin
Fix issue with config decl at class level (#2532)
00c55be 
* Fix issue with config decl at class level

* Add changes

* Update pydantic/main.py

Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>

* Update changes

Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrettyWood PrettyWood PrettyWood approved these changes

Assignees
No one assigned
Labels
bug V1 Bug related to Pydantic V1.X ready for review
Projects
None yet
Milestone
v1.8.2
Development

Successfully merging this pull request may close these issues.

BaseSettings-specific configuration cannot be passed to class as keyword arguments
3 participants
@uriyyo @samuelcolvin @PrettyWood