Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation with a BaseModel field and a custom root type #2451

Merged
merged 1 commit into from Mar 3, 2021

Conversation

PrettyWood
Copy link
Member

@PrettyWood PrettyWood commented Mar 2, 2021

Change Summary

__root__ key was added by mistake when the value to validate was already of right type

Related issue number

closes #2449

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #2451 (28aa4fb) into master (d619457) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2451   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         5084      5088    +4     
  Branches      1042      1042           
=========================================
+ Hits          5084      5088    +4     
Impacted Files Coverage Δ
pydantic/main.py 100.00% <100.00%> (ø)
pydantic/json.py 100.00% <0.00%> (ø)
pydantic/types.py 100.00% <0.00%> (ø)
pydantic/fields.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d619457...28aa4fb. Read the comment docs.

@PrettyWood PrettyWood added this to the v1.8.1 milestone Mar 2, 2021
@samuelcolvin samuelcolvin merged commit 3f84d14 into pydantic:master Mar 3, 2021
@samuelcolvin
Copy link
Member

👍 looks good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing downwards compatibility and bug with custom root types
2 participants