Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: variable length tuples of compound types #2421

Merged
merged 1 commit into from Mar 2, 2021

Conversation

PrettyWood
Copy link
Member

@PrettyWood PrettyWood commented Feb 27, 2021

Change Summary

I changed recently the code related to tuple to be more explicit and support () (empty tuple) but missed the case of variable length tuples of compound types

Related issue number

closes #2416

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@PrettyWood PrettyWood changed the title fix: tuple ellipsis with compound first argument fix: variable length tuples of compound types Feb 27, 2021
@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #2421 (3bc6777) into master (a8d50ae) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2421   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         5080      5081    +1     
  Branches      1041      1041           
=========================================
+ Hits          5080      5081    +1     
Impacted Files Coverage Δ
pydantic/fields.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8d50ae...3bc6777. Read the comment docs.

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @tlambert03 are you happy with this fix?

Copy link
Contributor

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me! thanks for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable length tuples not working in 1.8.0
3 participants