fix(mypy): fix custom Path and UUID related types
#2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But we have those errors 226: error: Item "str" of "Union[UUID, str]" has no attribute "hex" [union-attr] 227: error: Item "str" of "Union[UUID, str]" has no attribute "hex" [union-attr] 228: error: Item "str" of "Union[Path, str]" has no attribute "absolute" [union-attr] 229: error: Item "str" of "Union[Path, str]" has no attribute "absolute" [union-attr] 230: error: Item "str" of "Union[Path, str]" has no attribute "absolute" [union-attr] 231: error: Item "str" of "Union[Path, str]" has no attribute "absolute" [union-attr]
Codecov Report
@@ Coverage Diff @@
## master #2420 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 5080 5080
Branches 1041 1041
=========================================
Hits 5080 5080
Continue to review full report at Codecov.
|
samuelcolvin
approved these changes
Feb 27, 2021
|
great thank you. |
samuelcolvin
reviewed
Mar 2, 2021
| my_file_path: FilePath = Path(__file__) | ||
| my_file_path_str: FilePath = __file__ # type: ignore | ||
| my_dir_path: DirectoryPath = Path('.') | ||
| my_dir_path_str: DirectoryPath = '.' # type: ignore |
There was a problem hiding this comment.
I guess one day, when we solve koxudaxi/pydantic-pycharm-plugin#36 (comment) we could update the mypy plugin to avoid the need for all these # type: ignores
jwodder
added a commit
to jwodder/outgoing
that referenced
this pull request
Mar 3, 2021
This was referenced Mar 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
I went a bit too far with #2099 because I was first focused on "accepted" types and not "validated" types.
Related issue number
closes #2418
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)