Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python_requires metadata to require >=3.6.1 #2306

Merged
merged 2 commits into from Feb 13, 2021

Conversation

hukkin
Copy link

@hukkin hukkin commented Feb 1, 2021

At least this typing.Deque import requires Python version to be >=3.6.1.

This PR fixes python_requires metadata.

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #2306 (1ae018c) into master (b742c6f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2306   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          23       23           
  Lines        4477     4477           
  Branches      903      903           
=======================================
  Hits         4476     4476           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b742c6f...1ae018c. Read the comment docs.

@samuelcolvin
Copy link
Member

seems reasonable to me. Please can you:

  • add a change description
  • add a link in this PR to explain why Deque changed in a patch version, something strange must have happened

@hukkin
Copy link
Author

hukkin commented Feb 13, 2021

I guess the best explanation for this is given by Guido van Rossum https://bugs.python.org/issue29011#msg283660
It's still not quite clear to me personally why the addition couldn't wait until 3.7.0 release though.

@hukkin
Copy link
Author

hukkin commented Feb 13, 2021

  • add a change description

Is there a predefined process for this? Couldn't find anything in the docs

@hukkin
Copy link
Author

hukkin commented Feb 13, 2021

Ok I found the changelog process here. Maybe the contribution docs should link there?

@samuelcolvin
Copy link
Member

samuelcolvin commented Feb 13, 2021

I guess the best explanation for this is given by Guido van Rossum https://bugs.python.org/issue29011#msg283660
It's still not quite clear to me personally why the addition couldn't wait until 3.7.0 release though.

That's very weird, thanks for hunting it down.

Ok I found the changelog process here. Maybe the contribution docs should link there?

The PR template that you should have seen when creating the PR describes it pretty well, that's enough mostly.

Happy to accept a PR to update the contributing docs, otherwise I'll try to make it clearer when I get around to it.

@samuelcolvin samuelcolvin merged commit 40a925f into pydantic:master Feb 13, 2021
@samuelcolvin
Copy link
Member

Thanks a lot fo this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants