check ModelField().validate_always when inheriting #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1545 +/- ##
===========================================
- Coverage 100.00% 99.94% -0.06%
===========================================
Files 21 21
Lines 3772 3803 +31
Branches 749 756 +7
===========================================
+ Hits 3772 3801 +29
- Misses 0 1 +1
- Partials 0 1 +1
Continue to review full report at Codecov.
|
|
Please use a descriptive title on the PR. |
dcHHH
changed the title
This is my first PR. Sorry for the inconvenience I made. And the Change Summary of this PR is the reply to #1155 (comment) |
|
Looks good, please can you add a change file describing this change. |
sthagen
pushed a commit
to sthagen/pydantic-pydantic
that referenced
this pull request
Jun 29, 2020
fix pydantic#1155 * fix issure pydantic#1155 * add changes.1545-dcHHH.md * improve change description Co-authored-by: dchhh <hudacong@geetest.com> Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
sthagen
pushed a commit
to sthagen/pydantic-pydantic
that referenced
this pull request
Jun 29, 2020
* fix issure pydantic#1155 * add changes.1545-dcHHH.md * improve change description Co-authored-by: dchhh <hudacong@geetest.com> Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Indeed, the bug is originated from the change main.py:169. The fields of C is a deepcopy of it's parent class, so C.value_b.validate_always = B.value_b.validate_always = False
https://github.com/samuelcolvin/pydantic/blob/1eeb225c67f1131f948c5f129f5c2e56a4c2c6b7/pydantic/main.py#L881-L883
So value_b is not validated. Just move the assignment of validate_always from self.prepare() to self.populate_validators(), then the bug is solved.
Related issue number
#1155
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)