Add test coverage that default_factory doesn't copy its value #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therefromhere
force-pushed
the
test_singleton
branch
from
de89077
to
9f030d6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1523 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 3761 3761
Branches 748 748
=========================================
Hits 3761 3761 Continue to review full report at Codecov.
|
|
Test failure seems to be a codecov.io connection problem. |
|
thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adds an assertion that
default_factorycan be used to return a singleton.Related issue number
Resolves #1489
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)