Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs on dumping dataclasses to JSON #1487

Merged
merged 1 commit into from May 18, 2020
Merged

Added docs on dumping dataclasses to JSON #1487

merged 1 commit into from May 18, 2020

Conversation

mikegrima
Copy link
Contributor

@mikegrima mikegrima commented May 6, 2020

Change Summary

Added docs about dumping dataclasses to JSON. I was frustrated by the lack of them :D

Checklist

  • [N/A] Unit tests for the changes exist
  • [N/A] Tests pass on CI and coverage remains at 100%
  • [Y] Documentation reflects the changes where applicable
  • [Y] changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #1487 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1487   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3761      3761           
  Branches       748       748           
=========================================
  Hits          3761      3761           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5067508...4b15e60. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 28c2ac7 into pydantic:master May 18, 2020
@samuelcolvin
Copy link
Member

thanks a lot.

@mikegrima mikegrima deleted the jsondocs branch May 18, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants