Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent mutation of excludes/includes #1404

Merged

Conversation

AlexECX
Copy link
Contributor

@AlexECX AlexECX commented Apr 17, 2020

Change Summary

#1286 mutates the includes/excludes dictionary inside ValueItems, which makes them unusable after use. This PR aims to make includes/excludes arguments immutable.

Related issue number

Related to #959 (comment)

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@AlexECX AlexECX changed the title Prevent mutation of excludes/includes dictionaries inside ValueItems Prevent mutation of excludes/includes Apr 17, 2020
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #1404 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1404   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3736      3740    +4     
  Branches       739       741    +2     
=========================================
+ Hits          3736      3740    +4     
Impacted Files Coverage Δ
pydantic/typing.py 100.00% <ø> (ø)
pydantic/utils.py 100.00% <100.00%> (ø)
pydantic/types.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8bda5...05aa21c. Read the comment docs.

@AlexECX
Copy link
Contributor Author

AlexECX commented Apr 17, 2020

curl: (7) Failed to connect to codecov.io port 443: Connection timed out is that normal?

Edit: Oh well, pushing again fixed the problem.

@samuelcolvin samuelcolvin merged commit 52af916 into pydantic:master Apr 18, 2020
@samuelcolvin
Copy link
Member

good catch, thanks so much for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants