Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make secret types idempotent #1330

Merged
merged 3 commits into from Apr 18, 2020
Merged

make secret types idempotent #1330

merged 3 commits into from Apr 18, 2020

Conversation

Atheuz
Copy link
Contributor

@Atheuz Atheuz commented Mar 21, 2020 •
edited

Change Summary

make secret types idempotent

Related issue number

#1044

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/1330-atheuz.md

@codecov
Copy link

codecov bot commented Mar 21, 2020 •
edited

Codecov Report

Merging #1330 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #1330      +/-   ##
===========================================
+ Coverage   99.89%   100.00%   +0.10%     
===========================================
  Files          21        21              
  Lines        3689      3740      +51     
  Branches      726       741      +15     
===========================================
+ Hits         3685      3740      +55     
+ Misses          2         0       -2     
+ Partials        2         0       -2
Impacted Files Coverage Δ
pydantic/types.py 100.00% <100.00%> (ø)
pydantic/mypy.py 100.00% <0.00%> (ø)
pydantic/errors.py 100.00% <0.00%> (ø)
pydantic/fields.py 100.00% <0.00%> (ø)
pydantic/typing.py 100.00% <0.00%> (ø)
pydantic/decorator.py 100.00% <0.00%> (ø)
pydantic/validators.py 100.00% <0.00%> (ø)
pydantic/schema.py 100.00% <0.00%> (+0.55%) ⬆️
pydantic/utils.py 100.00% <0.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3243d2...259330f. Read the comment docs.

@Atheuz Atheuz mentioned this pull request Mar 21, 2020
Closed
samuelcolvin
samuelcolvin reviewed Apr 15, 2020
View reviewed changes
pydantic/types.py Outdated Show resolved Hide resolved
docs/examples/types_secret_types.py Outdated Show resolved Hide resolved
tests/test_types.py Outdated Show resolved Hide resolved
docs/examples/types_secret_types.py Outdated Show resolved Hide resolved
@LasseGravesen
remove idempotent from secret types example.
c69a20a 
add note to docs for idempotently creating secret types.
use isinstance for comparing when creating secret types idempotently.
add assert for idempotent secret types test.
@samuelcolvin samuelcolvin merged commit 097762b into pydantic:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelcolvin samuelcolvin Awaiting requested review from samuelcolvin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Atheuz @samuelcolvin @LasseGravesen