add pydantic.color.Color objects as available input for Color fields #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1258 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 3666 3669 +3
Branches 718 719 +1
=========================================
+ Hits 3666 3669 +3 Continue to review full report at Codecov.
|
leosussan
changed the title
fix: remove ._original conditional (logic is set earlier in the method) fix: removed pydantic.color.Color line from errorstring
leosussan
changed the title
|
awesome, thank you. Sorry about the docs build, I'll fix it when I'm back in the UK. |
RajatRajdeep
pushed a commit
to RajatRajdeep/pydantic
that referenced
this pull request
May 14, 2024
…ntic#1258) Signed-off-by: Lance Drane <dranelt@ornl.gov> Signed-off-by: Lance-Drane <ldraneutk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
If you pass a
pydantic.color.Colorobject to aColorfield, it will fail b/c the objectThis small edit allows for
Colorobjects as acceptable input for Color fields.Related issue number
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)