Skip to content

unix_socket_path in RedisSettings #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 24, 2022
Merged

Conversation

lazToum
Copy link
Contributor

@lazToum lazToum commented Aug 24, 2022

replaces #301

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #336 (fa8cbc6) into main (f154687) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files          11       11           
  Lines         994      999    +5     
  Branches      183      184    +1     
=======================================
+ Hits          983      988    +5     
  Misses          6        6           
  Partials        5        5           
Impacted Files Coverage Δ
arq/connections.py 95.80% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f154687...fa8cbc6. Read the comment docs.

@lazToum lazToum changed the title from rebase unix_socket_path in RedisSettings Aug 24, 2022
@lazToum
Copy link
Contributor Author

lazToum commented Aug 24, 2022

From #301, had to rebase.

@samuelcolvin
Copy link
Member

okay, in future, best if you rebase or merge without creating a new pull request.

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looking good.

lazToum and others added 2 commits August 24, 2022 12:40

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
@samuelcolvin samuelcolvin merged commit 76fd0a3 into python-arq:main Aug 24, 2022
@samuelcolvin
Copy link
Member

thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants