- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 184
the enqueue_time in context can use the direct timezone #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@samuelcolvin please |
I think I would rather stick to all timestamps being UTC, I don't want to add more complexity and depdencies unless absolutely necessary. Please can you provide an explanation of why you need this and how you will use it beyond "it's not good.". |
In my country,the default timezone is not the utc。So when the job is processing,the arq log(called ms_to_datetime)was less 8 hours。 Not easy to read for people who is not the programmer。 Thanks for your reply。 |
In my country, the default timezone is not UTC either. :-) Arguably it's even worse, because the timezone IS utc for half the year, then UTC+1 for the other half. Still, as far as I know arq only shows time differences in logs. If you want to log datetimes, in your own timezone you can implement that in your own code without modifying arq. I'm inclined to close this, unless there's some piece of code I'm missing that lots datetimes and would require a change to the code base to log correctly. |
but when the job was finished or other status。arq will print the log include the utc datetime,it's not good for reading。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'm prepared to accept this change, but this pull request needs a lot of work.
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
==========================================
- Coverage 98.84% 98.76% -0.08%
==========================================
Files 11 11
Lines 951 972 +21
Branches 161 165 +4
==========================================
+ Hits 940 960 +20
Misses 6 6
- Partials 5 6 +1
Continue to review full report at Codecov.
|
Thanks for your review. |
great, thanks so much. |
the enqueue_time in context is still utc, it's not good.