Sentinel timout not exposed

[meseta]

Sentinel timeout argument is not exposed. This setting we need to be able to adjust because the default aioredis 1.3.1 timeout value is 0.2s, too short for a lot of use-cases

The relevant code is here.

arq/arq/connections.py

Lines 216 to 236 in 88afd61

	if settings.sentinel:
	addr: Any = settings.host
	async def pool_factory(*args: Any, **kwargs: Any) -> Redis:
	client = await aioredis.sentinel.create_sentinel_pool(*args, ssl=settings.ssl, **kwargs)
	return client.master_for(settings.sentinel_master)
	else:
	pool_factory = functools.partial(
	aioredis.create_pool, create_connection_timeout=settings.conn_timeout, ssl=settings.ssl
	)
	addr = settings.host, settings.port
	try:
	pool = await pool_factory(addr, db=settings.database, password=settings.password, encoding='utf8')
	pool = ArqRedis(
	pool,
	job_serializer=job_serializer,
	job_deserializer=job_deserializer,
	default_queue_name=default_queue_name,
	)

I think settings.conn_timeout could be passed to aioredis.sentinel.create_sentinel_pool for the timeout argument. Internally, aioredis 1.3.1 passes this value onto the pools that it creates as well, making it work similarly to settings.conn_timeout when not using sentinel. We're currently working around this issue by monkey-patching the default argument in aioredis prior to any arq code.

In the future aioredis 2.0.0, it seems that sentinels can be instantiated with a socket_timeout argument. It would be worth exposing this to RedisSettings in arq to help with clusters that have higher latency. It may be best to wait for aioredis 2.0.0 before addressing this issue

[samuelcolvin]

PR welcome to fix this.

[meseta]

happy to help if we're still using arq in a couple months (nothing wrong with it, we're just switching a lot of stuff to kafka). I suggest waiting for aioredis 2.0.0, which releases imminently (see: aio-libs-abandoned/aioredis-py#930 (comment)), which seems to have substantially changed how sentinel is handled. Happy to take a look if we're still using arq at that point