Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff should not ignore errors #64

Open
aptituz opened this issue Oct 19, 2015 · 1 comment
Open

diff should not ignore errors #64

aptituz opened this issue Oct 19, 2015 · 1 comment

Comments

@aptituz
Copy link

aptituz commented Oct 19, 2015

If diff is failing for any reason (e.g. because of wrong arguments when providing them via diff_options) the diff method is silently failing, returning no diff but no error message either. That's probably because it's not evaluating stderr nor return code in the block where diff output is being processed.

@mainameiz
Copy link

Fixed in #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants