Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight performance boost on PickByKeys / OmitByKeys #446

Open
ericleb010 opened this issue Apr 25, 2024 · 0 comments · May be fixed by #447
Open

Slight performance boost on PickByKeys / OmitByKeys #446

ericleb010 opened this issue Apr 25, 2024 · 0 comments · May be fixed by #447

Comments

@ericleb010
Copy link

Using map indexing, we can improve the performance of PickByKeys / OmitByKeys, by ranging over the input key array and checking the input map, rather than ranging over the input map and then ranging over the input key array.

I'm assuming that in most applications, the size of the input map is larger than the size of the input key array, so this should make things faster in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant