Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ChannelMerge #241

Merged
merged 1 commit into from Oct 14, 2022
Merged

feat: add ChannelMerge #241

merged 1 commit into from Oct 14, 2022

Conversation

hhu-cc
Copy link
Contributor

@hhu-cc hhu-cc commented Oct 12, 2022

add two func ChannelCollector and BufferedChannelCollector for channel helper,
collect messages from multiple input channels into one channel.

@samber
Copy link
Owner

samber commented Oct 13, 2022

Hi @hhu-cc and thanks for this first contribution

I would name it ChannelMerge or ChannelAggregation instead of ChannelCollector, because the "collection" could be interpreted as a message source or an observable.

WDYT ? any other naming idea ?

Also, I wonder if it is a good idea to create an unbuffered helper.

@hhu-cc
Copy link
Contributor Author

hhu-cc commented Oct 14, 2022

Hi @samber
ChannelMerge is a better idea, I have already changed the func name and removed the unbuffered helper.

@hhu-cc hhu-cc changed the title feat: add ChannelCollector + BufferedChannelCollector feat: add ChannelMerge Oct 14, 2022
@samber samber merged commit d899a1c into samber:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants