Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: relax FindKeyBy constraint #205

Merged
merged 1 commit into from Aug 28, 2022

Conversation

powerman
Copy link
Contributor

Fixes #204

@codecov-commenter
Copy link

Codecov Report

Merging #205 (1d3ca41) into master (cf45927) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   90.62%   90.62%           
=======================================
  Files          13       13           
  Lines        1557     1557           
=======================================
  Hits         1411     1411           
  Misses        143      143           
  Partials        3        3           
Flag Coverage Δ
unittests 90.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
find.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@samber
Copy link
Owner

samber commented Aug 28, 2022

Gosh! I suppose It was a copy from lo.FindKey that needs a comparable type.

Thanks for the bug report!

@samber samber merged commit b890954 into samber:master Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FindKeyBy value constraint should be relaxed to any
3 participants