New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for caching headers primarily ETag/LastModified/If-Non-Match #136
Comments
Done |
I can't seem to use this feature. Probably need to add the feature here?
|
I forgot add it to Cargo.tom. Fixed. |
It is able to compile but don't think it is working as expected. let router = Router::new()
.hoop(extra::caching_headers::CachingHeaders::default())
.hoop(extra::compression::Compression::default())
.get(hello_world); I was expecting |
I fixed it, please check it again. |
Did you push the changes? I see version 0.33.1 as the latest commit. |
Please check again, version 0.33.2. |
If it is uncompressed response it works. As soon as I compress it doesn't work. |
Fixed |
Everything now works as expected. Thanks for fixing the bugs along the way! Feel free to release a new version so I can consume it directly from crates.io |
I would like to set appropriate caching headers for any responses include html and apis besides file. This improves performance on slow network when fetching it again.
I would like to have similar feature to trillium's caching-headers.
(In case you are wondering why I'm filing issue, I'm trying to port by blog from trillium to salvo https://github.com/prabirshrestha/rblog with the main reason being trillium not support first class error handling compared to salvo)
The text was updated successfully, but these errors were encountered: