Added optional 'host' parameter #319
Merged
+205
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the the root call failed, added optional host parameter to all relevent api calls and changed the master/slave required methods only check if the host param is empty.
|
This is fantastic support for solr, and an amazing asset for Salt. Some of the recent formatting in the docstrings made by whitinge to clean up the rendered documentation did not make it in, please take a look at the docstrings when you have some time to verify that my merge changes did not break any of the documentation |
|
Thanks, I'll take a look at those, if whitinge didn't beat me to it it. I see he has a pull request already this morning. |
arthurzenika
pushed a commit
to arthurzenika/salt
that referenced
this pull request
Sep 17, 2013
--hard must be explicitly enbled
dwoz
pushed a commit
to dwoz/salt
that referenced
this pull request
Jun 21, 2022
[3003.5] Fix bug in tcp transport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since solr uses alot of http api, it didn't really make sense to ALWAYS limit api calls to the local configured instance. So I added the optional 'host' parameter which if passed to slave or master only methods ignores the constraint. If it's not passed however, then the check will be performed.
Also fixed a bug in the match_index_versions method, where there was no else condition if the call to replication_status failed.