Fix custom inspection #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @BridgeAR to sign the Salesforce.com Contributor License Agreement. |
|
LGTM. Will merge once the assert API incompatibility thing gets resolved |
From Node.js 11 on custom inspection will not work with the `inspect` property anymore. This changes it to use the newer custom inspection symbol if available. To stay backwarts compatible it keeps the old function in place in case it is called directly by users.
BridgeAR
force-pushed
the
fix-custom-inspection
branch
from
5c1d492
to
a662bbb
Compare
|
Rebased due to conflicts. |
wjhsf
pushed a commit
that referenced
this pull request
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Node.js 11 on custom inspection will not work with the
inspectproperty anymore. This changes it to use the newer custom inspection
symbol if available. To stay backwarts compatible it keeps the old
function in place in case it is called directly by users.