Apr2018 node versions #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re-tested with |
|
@stash this fix is actually not correct. The message was never tested on older Node.js versions. The behavior is also documented: https://nodejs.org/api/assert.html#assert_assert_throws_block_error_message. The message would have been used in case no error would have been thrown. The reason why Error instances work in Node.js >= 10 supports validation objects and errors are accepted as such as well (the non-enumerable properties I opened #113 to address this in a backwards compatible way. |
stash
force-pushed
the
apr2018-node-versions
branch
from
d8006be
to
0d87461
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Node 10.x and 9.x