chore: update deps #238
chore: update deps #238
Conversation
| "fast-glob": "^3.2.5", | ||
| "jest": "26.6.3", | ||
| "fast-glob": "^3.2.7", | ||
| "jest": "27.0.6", |
There was a problem hiding this comment.
FYI, this will require a major version bump.
There was a problem hiding this comment.
Is there any way to support both jest 26 and 27, like we do in lwc-test?
There was a problem hiding this comment.
Packages in lwc-test are jest plugins while sfdx-lwc-jest is a jest wrapper. I don't think it's possible with the way sfdx-lwc-jest is set up to distribute multiple versions of jest.
An alternative approach would be to externalize jest dependency and require all the SFDX projects to install jest as a peer dependency. In general Salesforce developers aren't familiar enough with the NodeJS ecosystem and NPM to deal with peer dependencies. Based on my experience Salesforce developers are looking for packaged and easy-to-install solutions.
@nolanlawson Are you concerned about the potential breaking changes jest@27 introduces?
There was a problem hiding this comment.
@pmdartus Based on the release notes it seems to me that there are things that can start breaking in v27. As long as we release a major version bump we should be fine. I didn't realize this was a wrapper and not a plugin.
| "eslint": "^7.28.0", | ||
| "husky": "^5.2.0", | ||
| "eslint": "^7.30.0", | ||
| "husky": "^7.0.1", |
There was a problem hiding this comment.
You can now remove https://github.com/salesforce/sfdx-lwc-jest/blob/master/.husky/.gitignore
Update deps