Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set package node engines #228

Conversation

jasonschroeder-sfdc
Copy link
Collaborator

Explicitly spell-out the nodeJS engines supported by each published package.
Also, include a badge. (It's broken right now but will light up after this change is released)

Declare the nodejs versions supported by each scoped package.
See: https://docs.npmjs.com/cli/v6/configuring-npm/package-json#engines

BREAKING CHANGE: Explicitly supporting NodeJS 14.x and 16.x
Add supported nodejs engines badge.
@jasonschroeder-sfdc jasonschroeder-sfdc requested a review from a team as a code owner October 20, 2022 05:55
@jasonschroeder-sfdc jasonschroeder-sfdc self-assigned this Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #228 (f9414d1) into master (6b7a180) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files          22       22           
  Lines         323      323           
  Branches       66       66           
=======================================
  Hits          316      316           
  Misses          7        7           

@jasonschroeder-sfdc jasonschroeder-sfdc merged commit 42de911 into salesforce:master Oct 20, 2022
@jasonschroeder-sfdc jasonschroeder-sfdc deleted the set-package-node-engines branch October 20, 2022 06:01
github-actions bot pushed a commit that referenced this pull request Oct 20, 2022
## [4.0.0](v3.1.0...v4.0.0) (2022-10-20)

### ⚠ BREAKING CHANGES

* Explicitly supporting NodeJS 14.x and 16.x
* `sa11y` will no longer support Node.js 12, which is EOL since 30 April 2022

### Features

* remove support for Node.js 12 ([#116](#116)) ([43ade48](43ade48))
* semantic release ([#227](#227)) ([6b7a180](6b7a180))
* tsconfig package for tsconfig.json ([#174](#174)) ([5ff2fd2](5ff2fd2))
* webdriver7 ([#150](#150)) ([70dafc2](70dafc2))

### Bug Fixes

* set package.json node engines ([#228](#228)) ([42de911](42de911))
@github-actions
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants