feat: getElementsByName #45
Merged
+216
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedconn
commented
Sep 29, 2020
tedconn
commented
Sep 29, 2020
| @@ -281,6 +295,12 @@ function attachSourceIfNecessary ({ nodes }, selector) { | |||
| } | |||
| } | |||
|
|
|||
| function assertIsDocumentOrShadowRoot (context) { | |||
| if (context.nodeType !== 11 && context.nodeType !== 9) { | |||
There was a problem hiding this comment.
I realized duck typing this will be a cleaner approach and work across windows.
nolanlawson
requested changes
Sep 29, 2020
| ] | ||
| assertResultEqual(name, getElementsByName(name, context), expected, true) | ||
|
|
||
| name = 'test' |
There was a problem hiding this comment.
Just as a sanity check, can we test for names like tEsT and ensure that it doesn't match? (Looks like getElementsByName is case-sensitive.)
tedconn
force-pushed
the
get-elements-by-name
branch
from
3e4341e to
70e6598
Compare
nolanlawson
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
Document.getElementsByName