-
Notifications
You must be signed in to change notification settings - Fork 434
Card component destructure aria data props #3071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card component destructure aria data props #3071
Conversation
…SLDSCard component
Thanks for opening this pull request! 💯 This is a community-driven project, and we can't do it without your participation. Please check out our contributing guidelines and review the Contributor Checklist if you haven't already, to make sure everything is squared away. CircleCI will take about 10 minutes to run through the same items that are on the Contributor checklist with a pass/fail check below. Please fix any issues that cause CircleCI to fail or ask for clarification--we try, but sometimes the errors can be unclear. |
Thanks for the contribution! Before we can merge this, we need @BenjaminWFox-MuleSoft to sign the Salesforce.com Contributor License Agreement. |
Congrats on merging your first pull request to Design System React! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
Fixes #3068
Additional description
Adds functionality to destructured
aria-
anddata-
props on the SLDSCard component.These props will be destructured on to the root
article
element.CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
Note:
The tests at http://localhost:8001/ have 2 failing (for SLDSComboBox), but it looks like this is also present on the master branch, so not addressed in this PR.
npm run lint:fix
has been run and linting passes.components/component-docs.json
CI tests pass (npm test
).REVIEWER checklist (do not remove)
components/component-docs.json
tests.Required only if there are markup / UX changes
last-slds-markup-review
inpackage.json
and push.last-accessibility-review
, topackage.json
and push.npm run local-update
within locally cloned site repo to confirm the site will function correctly at the next release.