Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage build stops waiting for response #35670

Closed
2 tasks done
beew opened this issue May 22, 2023 · 1 comment · Fixed by #37995
Closed
2 tasks done

sage build stops waiting for response #35670

beew opened this issue May 22, 2023 · 1 comment · Fixed by #37995
Labels
t: bug
Milestone
sage-10.4

Comments

@beew
Copy link

beew commented May 22, 2023 •
edited

Is there an existing issue for this?

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.

Did you read the documentation and troubleshoot guide?

  • I have read the documentation and troubleshoot guide

Environment

- **OS**: Ubuntu 22.04
- **Sage Version**: 9.8, 10.0 in fact all versions I have built.

Steps To Reproduce

I am not sure if this is a bug or intended When building sage, the build process stops after installing a component with output likes

"Finished installing x". To continue the user have to press return,

then sage will output

"Ok, will install y"

Expected Behavior

build should continue without requiring user input. It takes a long time for sage to build, I would like it to just type "make" and let it run so I could do something else instead of having to wait around to press return and wait for

"ok"

Actual Behavior

See above

Additional Information

No response
@beew beew added the t: bug label May 22, 2023
@jhpalmieri
Copy link
Member

This should happen only if you are trying to install an experimental package. What ./configure command did you use?

@mkoeppe mkoeppe added this to the sage-10.4 milestone May 3, 2024
@mkoeppe mkoeppe mentioned this issue May 12, 2024
Merged
5 tasks
vbraun pushed a commit to vbraun/sage that referenced this issue May 15, 2024
sagemathgh-37995: Remove interactive confirmation for installing expe…
3f818c3 
…rimental packages

<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

This removes some complexity and eliminates the pitfall that Sage is
waiting for confirmation from the user but the query is hidden in long
terminal output from other package installations.
With this PR we just exit with an error and tell users what to do.

Fixes sagemath#35670.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

URL: sagemath#37995
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this issue May 18, 2024
sagemathgh-37995: Remove interactive confirmation for installing expe…
c65935d 
…rimental packages

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

This removes some complexity and eliminates the pitfall that Sage is
waiting for confirmation from the user but the query is hidden in long
terminal output from other package installations.
With this PR we just exit with an error and tell users what to do.

Fixes sagemath#35670.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37995
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this issue May 18, 2024
sagemathgh-37995: Remove interactive confirmation for installing expe…
dc58150 
…rimental packages

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

This removes some complexity and eliminates the pitfall that Sage is
waiting for confirmation from the user but the query is hidden in long
terminal output from other package installations.
With this PR we just exit with an error and tell users what to do.

Fixes sagemath#35670.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37995
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this issue May 24, 2024
sagemathgh-37995: Remove interactive confirmation for installing expe…
bcf2709 
…rimental packages

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

This removes some complexity and eliminates the pitfall that Sage is
waiting for confirmation from the user but the query is hidden in long
terminal output from other package installations.
With this PR we just exit with an error and tell users what to do.

Fixes sagemath#35670.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37995
Reported by: Matthias Köppe
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t: bug
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging a pull request may close this issue.

Remove interactive confirmation for installing experimental packages mkoeppe/sage
3 participants
@jhpalmieri @beew @mkoeppe