Support sabre/xml v4 #607
Merged
Support sabre/xml v4 #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 4.5 #607 +/- ##
============================================
+ Coverage 98.35% 98.57% +0.22%
Complexity 1897 1897
============================================
Files 71 71
Lines 4548 5483 +935
============================================
+ Hits 4473 5405 +932
- Misses 75 78 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Alternatively I think we could release 4.5.1 as 4.5.3 again. Then we could use 4.5.2 and publish it as a new major. |
|
The changes here look fine if you prefer it |
phil-davis
force-pushed
the
support-sabre-xml-v4-4.5-series
branch
from
9a857cd
to
d672f6c
Compare
phil-davis
force-pushed
the
support-sabre-xml-v4-4.5-series
branch
from
d672f6c
to
bad63c0
Compare
Do you think that the If I just re=release 4.5.1 as 4.5.3 then the ability to use If I do this PR, then @gharlan (and others) can have the latest |
|
I don't have a strong opinion which way to go from here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally released 4.5.2 on Friday with all the code in
masterbranch. That code has various PHP 7.4-only things that will not work properly on PHP 7.1 7.2 7.3 etc.See comment #588 (comment) which reports this mistake.
This PR:
If I merge this and then release 4.5.3 from the 4.5 branch, I think that it should be fine.
The added return types are all supported from PHP 7.1 upward, so that is nice.
The only thought that I have now is that if consumers have implemented child classes that redeclare
xmlSerializeorxmlDeserializethen maybe they will also have to add a return typevoidorarray? And so that will mean that the release is not strictly backward-compatible. And so a patch release is not correct.Thoughts please @staabm @DeepDiver1975 or anyone.