Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sabre/xml v4 #603

Merged
merged 1 commit into from Jan 20, 2023
Merged

Support sabre/xml v4 #603

merged 1 commit into from Jan 20, 2023

Conversation

gharlan
Copy link
Contributor

@gharlan gharlan commented Jan 19, 2023

I would like to use sabre/vobject together with latest sabre/xml v4.
Latest vobject release still uses sabre/xml v2.

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #603 (21918bf) into master (041ceaf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #603   +/-   ##
=========================================
  Coverage     98.76%   98.76%           
  Complexity     1865     1865           
=========================================
  Files            71       71           
  Lines          5325     5325           
=========================================
  Hits           5259     5259           
  Misses           66       66           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. the main diff of 4.x was the sabre/uri difference described in https://github.com/sabre-io/xml/releases/tag/4.0.0

I think we only need to make sure, when we release this change that we also note about this sabre/uri implication in the releases notes.

the failling builds are interessting though

@phil-davis
Copy link
Contributor

I restrted the failed jobs, and they failed again, so there is "something special" that needs looking into.

@phil-davis
Copy link
Contributor

See #604 - there are new problems in CI that are unrelated to this PR.
I will see if they can be resolved first, before making the change to sabre/xml v4.

@phil-davis phil-davis self-assigned this Jan 20, 2023
@phil-davis phil-davis merged commit 3af541a into sabre-io:master Jan 20, 2023
@phil-davis
Copy link
Contributor

@phil-davis phil-davis mentioned this pull request Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants