Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove utf8_encode #597

Merged
merged 1 commit into from Oct 9, 2022
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 9, 2022

Fixes #596

Use explicit calls to mb_convert_encoding

@phil-davis phil-davis self-assigned this Oct 9, 2022
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #597 (f41f276) into master (bc48391) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #597      +/-   ##
============================================
- Coverage     98.53%   98.53%   -0.01%     
  Complexity     1865     1865              
============================================
  Files            71       71              
  Lines          4159     4157       -2     
============================================
- Hits           4098     4096       -2     
  Misses           61       61              
Impacted Files Coverage Δ
lib/Parser/MimeDir.php 99.54% <100.00%> (-0.01%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phil-davis phil-davis merged commit 8157443 into sabre-io:master Oct 9, 2022
@phil-davis phil-davis deleted the remove-utf8_encode branch October 9, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.2 utf8_encode deprecated
2 participants