Fully ignore invalid lines #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
=========================================
Coverage 98.34% 98.34%
- Complexity 1891 1892 +1
=========================================
Files 71 71
Lines 4534 4536 +2
=========================================
+ Hits 4459 4461 +2
Misses 75 75
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
heiglandreas
force-pushed
the
ignoreInvalidIcalendarLinesWhenOptionIsSet
branch
6 times, most recently
from
2cf5f06
to
758ba35
Compare
phil-davis
reviewed
Jun 24, 2022
|
@heiglandreas I am doing some work in this repo, so I have time to look over the pending PRs. |
Previously when OPTION_IGNORE_INVALID_LINES was set any invalid content of a property was ignored. With this change now also invalid properties themselves are ignored. This will help importing feeds that contain broken multi-line contents where newlines are not propperly escaped and therefore parts of the multiline content show up as property themselves. Without this addition the import will then break and not import anything at all. With this change added an import will now succeed when invalid lines shall be ignored. Without the option set everything will behave as before.
phil-davis
force-pushed
the
ignoreInvalidIcalendarLinesWhenOptionIsSet
branch
from
758ba35
to
69e49df
Compare
|
@heiglandreas I am allowed to push to your branch - so I have rebased and fixed the typo. |
|
Thanks! |
phil-davis
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when OPTION_IGNORE_INVALID_LINES was set any invalid content of a property was ignored.
With this change now also invalid properties themselves are ignored.
This will help importing feeds that contain broken multi-line contents where newlines are not propperly escaped and therefore parts of the multiline content show up as property themselves. Without this addition the import will then break and not import anything at all. With this change added an import will now succeed when invalid lines shall be ignored.
Without the option set everything will behave as before.